Bug 84942

Summary: MediaStream API: Change LocalMediaStream::stop to be synchronous
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: adam.bergkvist, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-04-26 04:02:33 PDT
Since I changed LocalMediaStream to be a ActiveDOMObject recently the stop behaviour needs to change since it is no longer a good idea to start a timer when called.
Attachments
Patch (3.42 KB, patch)
2012-04-26 04:06 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (2.91 KB, patch)
2012-04-30 01:39 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-04-26 04:06:09 PDT
Created attachment 138970 [details] Patch
James Robinson
Comment 2 2012-04-30 01:21:22 PDT
Comment on attachment 138970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138970&action=review > Source/WebCore/Modules/mediastream/LocalMediaStream.cpp:2 > + * Copyright (C) 2012 Google Inc. All rights reserved. we don't do this in WebKit, just leave the date alone > Source/WebCore/Modules/mediastream/LocalMediaStream.h:2 > + * Copyright (C) 2012 Google Inc. All rights reserved. same here
Tommy Widenflycht
Comment 3 2012-04-30 01:39:50 PDT
Created attachment 139426 [details] Patch
Tommy Widenflycht
Comment 4 2012-04-30 01:41:16 PDT
Comment on attachment 138970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138970&action=review >> Source/WebCore/Modules/mediastream/LocalMediaStream.cpp:2 >> + * Copyright (C) 2012 Google Inc. All rights reserved. > > we don't do this in WebKit, just leave the date alone Done. >> Source/WebCore/Modules/mediastream/LocalMediaStream.h:2 >> + * Copyright (C) 2012 Google Inc. All rights reserved. > > same here Done.
Adam Bergkvist
Comment 5 2012-04-30 07:18:20 PDT
This patch changes specified (and testable) API behavior. The "ended" event will be dispatched synchronously when LocalMediaStream.stop() is called from JavaScript. I don't think calling MediaStreamCenter::didStopLocalMediaStream() from ActiveDOMObject::stop() is the right approach. I've posted a bug to discuss this. See http://webkit.org/b/85191
WebKit Review Bot
Comment 6 2012-04-30 10:43:55 PDT
Comment on attachment 139426 [details] Patch Clearing flags on attachment: 139426 Committed r115649: <http://trac.webkit.org/changeset/115649>
WebKit Review Bot
Comment 7 2012-04-30 10:43:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.