Bug 85883

Summary: MediaStream API: Adding a test for constructed from JS MediaStreams
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: Tools / TestsAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56587    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-05-08 07:04:47 PDT
MediaStreams can now be created from JS but lacked tests. Fixed.
Attachments
Patch (3.63 KB, patch)
2012-05-08 07:10 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (8.57 KB, patch)
2012-05-09 02:37 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-05-08 07:10:48 PDT
Created attachment 140714 [details] Patch
Kent Tamura
Comment 2 2012-05-09 02:16:31 PDT
Comment on attachment 140714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140714&action=review > LayoutTests/fast/mediastream/MediaStreamConstructor.html:14 > +function shouldNotThrow(expression) > +{ * This should be in js-test-pre.js. * The position of { is inconsistent with other functions. > LayoutTests/fast/mediastream/MediaStreamConstructor.html:21 > + try { > + eval(expression); > + testPassed(expression + " did not throw exception."); > + } catch(e) { > + testFailed(expression + " should not throw exception. Threw exception " + e); > + } > +} We usually use four-space indentation in JavaScript code. We usually put ' ' after 'catch'.
Tommy Widenflycht
Comment 3 2012-05-09 02:37:10 PDT
Created attachment 140894 [details] Patch
Tommy Widenflycht
Comment 4 2012-05-09 02:37:50 PDT
Comment on attachment 140714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140714&action=review >> LayoutTests/fast/mediastream/MediaStreamConstructor.html:14 >> +{ > > * This should be in js-test-pre.js. > > * The position of { is inconsistent with other functions. Fixed. >> LayoutTests/fast/mediastream/MediaStreamConstructor.html:21 >> +} > > We usually use four-space indentation in JavaScript code. > We usually put ' ' after 'catch'. Fixed.
Kent Tamura
Comment 5 2012-05-09 03:11:24 PDT
Comment on attachment 140894 [details] Patch Looks ok
WebKit Review Bot
Comment 6 2012-05-09 03:48:29 PDT
Comment on attachment 140894 [details] Patch Clearing flags on attachment: 140894 Committed r116511: <http://trac.webkit.org/changeset/116511>
WebKit Review Bot
Comment 7 2012-05-09 03:48:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.