Bug 87201

Summary: REGRESSION(r118095): "Causing crashes on Mac in WebCore::StyleResolver::adjustRenderStyle (Requested by sundiamonde on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jamesr, slewis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87186    
Attachments:
Description Flags
ROLLOUT of r118095 none

WebKit Review Bot
Reported 2012-05-22 21:03:45 PDT
http://trac.webkit.org/changeset/118095 broke the build: "Causing crashes on Mac in WebCore::StyleResolver::adjustRenderStyle (Requested by sundiamonde on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r118095 (15.89 KB, patch)
2012-05-22 21:04 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-05-22 21:04:44 PDT
Created attachment 143446 [details] ROLLOUT of r118095 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Stephanie Lewis
Comment 2 2012-05-22 21:08:58 PDT
On Debug it's asserting, on Release it is just crashing. It is crashing Safari in addition to DRT. These are the two tests: +fast/css-generated-content/spellingToolTip-assert.html +fast/css-generated-content/positioned-div-with-floating-after-content-crash.html Here is the assertion ASSERTION FAILED: this /Volumes/Data/slave/lion-intel-debug/build/Source/WebCore/dom/Node.h(410) : WebCore::Document *WebCore::Node::document() const 1 0x10235b4d6 WebCore::Node::document() const 2 0x103a0afb6 WebCore::StyleResolver::adjustRenderStyle(WebCore::RenderStyle*, WebCore::RenderStyle*, WebCore::Element*) 3 0x103a13ac0 WebCore::StyleResolver::pseudoStyleForElement(WebCore::PseudoId, WebCore::Element*, WebCore::RenderStyle*) 4 0x103711f10 WebCore::RenderObject::getUncachedPseudoStyle(WebCore::PseudoId, WebCore::RenderStyle*, WebCore::RenderStyle*) const 5 0x103716302 WebCore::RenderObject::getCachedPseudoStyle(WebCore::PseudoId, WebCore::RenderStyle*) const 6 0x10371a81f WebCore::RenderObjectChildList::updateBeforeAfterContent(WebCore::RenderObject*, WebCore::PseudoId, WebCore::RenderObject const*) 7 0x1035738ed WebCore::RenderBlock::updateBeforeAfterContent(WebCore::PseudoId) 8 0x103573201 WebCore::RenderBlock::styleDidChange(WebCore::StyleDifference, WebCore::RenderStyle const*) 9 0x103712cb8 WebCore::RenderObject::setStyle(WTF::PassRefPtr<WebCore::RenderStyle>) 10 0x10371237b WebCore::RenderObject::setAnimatableStyle(WTF::PassRefPtr<WebCore::RenderStyle>) 11 0x10348a983 WebCore::Node::setRenderStyle(WTF::PassRefPtr<WebCore::RenderStyle>) 12 0x1029160f4 WebCore::Element::recalcStyle(WebCore::Node::StyleChange) 13 0x10270f312 WebCore::Document::recalcStyle(WebCore::Node::StyleChange) 14 0x10270c6d5 WebCore::Document::styleResolverChanged(WebCore::StyleResolverUpdateFlag) 15 0x102715a44 WebCore::Document::removePendingSheet() 16 0x1039eea31 WebCore::StyleElement::sheetLoaded(WebCore::Document*) 17 0x102bc422e WebCore::HTMLStyleElement::sheetLoaded() 18 0x10267c2ee WebCore::StyleSheetInternal::checkLoaded() 19 0x1039ee868 WebCore::StyleElement::createSheet(WebCore::Element*, int, WTF::String const&) 20 0x1039ede07 WebCore::StyleElement::process(WebCore::Element*) 21 0x1039ee1b6 WebCore::StyleElement::finishParsingChildren(WebCore::Element*) 22 0x102bc38fb WebCore::HTMLStyleElement::finishParsingChildren() 23 0x102b3d5bd WebCore::HTMLElementStack::popCommon() 24 0x102b3d7cd WebCore::HTMLElementStack::pop() 25 0x102bed675 WebCore::HTMLTreeBuilder::processEndTag(WebCore::AtomicHTMLToken&) 26 0x102be9bae WebCore::HTMLTreeBuilder::processToken(WebCore::AtomicHTMLToken&) 27 0x102be8cbb WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken(WebCore::AtomicHTMLToken&) 28 0x102be8bcc WebCore::HTMLTreeBuilder::constructTreeFromToken(WebCore::HTMLToken&) 29 0x102b1f82b WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) 30 0x102b1f25d WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) 31 0x102b2034f WebCore::HTMLDocumentParser::append(WebCore::SegmentedString const&)
WebKit Review Bot
Comment 3 2012-05-22 21:17:49 PDT
Comment on attachment 143446 [details] ROLLOUT of r118095 Clearing flags on attachment: 143446 Committed r118116: <http://trac.webkit.org/changeset/118116>
WebKit Review Bot
Comment 4 2012-05-22 21:17:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.