Bug 90036

Summary: [Platform] Implement localizedDecimalSeparator function
Product: WebKit Reporter: yosin
Component: PlatformAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 88970    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3
none
Patch 4 none

yosin
Reported 2012-06-26 19:03:25 PDT
For displaying millisecond in Time input fields UI needs to know localized decimal separator, e.g. "." in English, "," in French. Because date time format obtained from some platforms don't have millisecond, e.g. ICU.
Attachments
Patch 1 (6.81 KB, patch)
2012-06-26 22:58 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (6.87 KB, patch)
2012-06-26 23:30 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (6.87 KB, patch)
2012-06-26 23:52 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Patch 4 (6.99 KB, patch)
2012-06-27 21:28 PDT, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-06-26 22:58:31 PDT
Created attachment 149683 [details] Patch 1
yosin
Comment 2 2012-06-26 22:59:10 PDT
Comment on attachment 149683 [details] Patch 1 Could you review this patch? Thanks in advance. * Local build on CR-Linux * Local build on Mac
WebKit Review Bot
Comment 3 2012-06-26 23:15:36 PDT
Comment on attachment 149683 [details] Patch 1 Attachment 149683 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13097680
yosin
Comment 4 2012-06-26 23:30:02 PDT
Created attachment 149689 [details] Patch 2
yosin
Comment 5 2012-06-26 23:31:08 PDT
Comment on attachment 149689 [details] Patch 2 Could you review this patch? Thanks in advance. == Change since last request == * Add #if ENABLE(INPUT_TIME_FIELDS) to LocalizedNumberICU.cpp
WebKit Review Bot
Comment 6 2012-06-26 23:39:32 PDT
Comment on attachment 149689 [details] Patch 2 Attachment 149689 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13087780
yosin
Comment 7 2012-06-26 23:52:25 PDT
Created attachment 149692 [details] Patch 3
yosin
Comment 8 2012-06-26 23:53:12 PDT
Comment on attachment 149692 [details] Patch 3 Could you review this patch? Thanks in advance. == Changes since last request == * Fix LocalizedNumberICUTest.cpp
Kent Tamura
Comment 9 2012-06-27 20:32:06 PDT
Comment on attachment 149692 [details] Patch 3 ok except the ENABLE flag name.
yosin
Comment 10 2012-06-27 21:28:36 PDT
Created attachment 149863 [details] Patch 4
yosin
Comment 11 2012-06-27 21:29:25 PDT
Comment on attachment 149692 [details] Patch 3 Could you review this patch? Thanks in advance. == Change since last review == * Rename ENABLE flag to ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
Kent Tamura
Comment 12 2012-06-27 21:55:08 PDT
Comment on attachment 149863 [details] Patch 4 ok
yosin
Comment 13 2012-06-27 21:58:14 PDT
Comment on attachment 149863 [details] Patch 4 Clearing flags on attachment: 149863 Committed r121404: <http://trac.webkit.org/changeset/121404>
yosin
Comment 14 2012-06-27 21:58:21 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 15 2012-07-27 01:13:46 PDT
Comment on attachment 149692 [details] Patch 3 Cleared review? from obsolete attachment 149692 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.