Bug 91969

Created attachment 153996 [details] Patch

Comment on attachment 153996 [details] Patch I think it's better to always have ProgressInnerElement regardless of the existence of author shadows. Having two forms of the tree is complicated. Also, please add a test for matching the newly introduced pseudo id.

It's not so clear that how do we style a progress element itself and the inner element. Let me try it though.

Created attachment 154568 [details] WIP

This patch needs to update several test expectations, I believe.

Comment on attachment 154568 [details] WIP Attachment 154568 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13344679 New failing tests: fast/dom/shadow/input-with-validation-without-shadow.html fast/dom/HTMLProgressElement/progress-element-markup.html fast/dom/HTMLProgressElement/progress-element.html fast/dom/HTMLProgressElement/indeterminate-progress-001.html fast/dom/HTMLProgressElement/progress-writing-mode.html fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html fast/dom/HTMLProgressElement/progress-clone.html

Created attachment 154587 [details] Archive of layout-test-results from gce-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Created attachment 154605 [details] WIP

Comment on attachment 154605 [details] WIP Attachment 154605 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13345672 New failing tests: fast/dom/shadow/shadowdom-for-progress-multiple.html fast/dom/shadow/shadowdom-for-progress-without-shadow-element.html fast/dom/shadow/shadowdom-for-progress-with-style.html

Created attachment 154616 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment on attachment 154605 [details] WIP Attachment 154605 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13379079

Created attachment 155714 [details] Patch

Comment on attachment 155714 [details] Patch Attachment 155714 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13411248

Comment on attachment 155714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155714&action=review > LayoutTests/platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:7 > + RenderProgress {DIV} at (0,0) size 160x16 Is it possible to suppress this extra renderer like <img> does?

(In reply to comment #14) > (From update of attachment 155714 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155714&action=review > > > LayoutTests/platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:7 > > + RenderProgress {DIV} at (0,0) size 160x16 > > Is it possible to suppress this extra renderer like <img> does? Let me try

Created attachment 155776 [details] Patch

Created attachment 155960 [details] Patch

Comment on attachment 155960 [details] Patch Attachment 155960 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13403844

Created attachment 155969 [details] Patch

Comment on attachment 155969 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155969&action=review > Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:607 > + Please remove unnecessary change. > Source/WebCore/rendering/RenderThemeChromiumSkia.cpp:-612 > - Ditto.

Created attachment 156268 [details] Patch for landing

Comment on attachment 156268 [details] Patch for landing Attachment 156268 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13423728 New failing tests: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html fast/dom/HTMLProgressElement/progress-writing-mode.html fast/dom/HTMLProgressElement/indeterminate-progress-001.html

Created attachment 156295 [details] Archive of layout-test-results from apple-mac-3 The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: apple-mac-3 Port: <class 'webkitpy.common.config.ports.MacPort'> Platform: Mac OS X 10.7.4

Created attachment 156311 [details] Patch for landing

Created attachment 156601 [details] Patch for landing

Comment on attachment 156601 [details] Patch for landing Rejecting attachment 156601 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rce/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 48>At revision 134927. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Total errors found: 0 in 1 files Full output: http://queues.webkit.org/results/13435756

Created attachment 156645 [details] Patch for landing

Comment on attachment 156645 [details] Patch for landing Clearing flags on attachment: 156645 Committed r124754: <http://trac.webkit.org/changeset/124754>

All reviewed patches have been landed. Closing bug.