Bug 92106

Summary: MediaStream API: Remove DeprecatedPeerConnection
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, adam.bergkvist, eric.carlson, feature-media-reviews, gyuyoung.kim, ojan, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459, 80589    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-07-24 05:51:19 PDT
Since we are getting ready to add an updated PeerConnection the old DeprecatedPeerConnection will have to go.
Attachments
Patch (103.36 KB, patch)
2012-07-24 06:23 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (104.58 KB, patch)
2012-07-24 08:27 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (104.59 KB, patch)
2012-07-26 01:39 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-07-24 06:23:46 PDT
Created attachment 154040 [details] Patch
Tommy Widenflycht
Comment 2 2012-07-24 06:24:24 PDT
No code changes, except for deleted code.
Gyuyoung Kim
Comment 3 2012-07-24 07:06:56 PDT
Comment on attachment 154040 [details] Patch Attachment 154040 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13332379
Tommy Widenflycht
Comment 4 2012-07-24 08:27:43 PDT
Created attachment 154070 [details] Patch
Adam Barth
Comment 5 2012-07-24 10:48:27 PDT
Comment on attachment 154070 [details] Patch I'm glad we're removing this code. Let's give Adam a chance to comment in case he has thoughts on this patch.
Tommy Widenflycht
Comment 6 2012-07-26 01:27:09 PDT
I haven't heard anything so committing.
WebKit Review Bot
Comment 7 2012-07-26 01:28:24 PDT
Comment on attachment 154070 [details] Patch Rejecting attachment 154070 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: rm/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt patching file LayoutTests/platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt patching file LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt patching file LayoutTests/platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13343688
Tommy Widenflycht
Comment 8 2012-07-26 01:39:52 PDT
Created attachment 154576 [details] Patch
Tommy Widenflycht
Comment 9 2012-07-26 01:40:34 PDT
Just rebased to fix build file merge errors.
WebKit Review Bot
Comment 10 2012-07-26 03:34:35 PDT
Comment on attachment 154576 [details] Patch Clearing flags on attachment: 154576 Committed r123724: <http://trac.webkit.org/changeset/123724>
WebKit Review Bot
Comment 11 2012-07-26 03:34:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.