Bug 92661

Summary: flexbox should avoid floats
Product: WebKit Reporter: Tony Chang <tony>
Component: Layout and RenderingAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://plexode.com/u/#A9float28%3A27%3C-6le25div24%3E21%22j*(9ed(5.!n)75(sty6%3D2(%20b!7%2F54~http://p6xode.com/eval3/#ht=)1986ft14I(am(a*%0A)1display8(-webkit-f6x%3B14)1c6ar8both14This(is(a(f6xbox%2C!754it(should(be(next(the*!
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-01
none
Patch for landing none

Tony Chang
Reported 2012-07-30 11:05:53 PDT
Currently if a flexbox comes after a floated item, it's overlapping the float rather than being positioned around it. See the URL for an example. The flexbox should avoid the float. For example, change the display to -webkit-box (old flexbox) or table and you can see how the box avoids the float.
Attachments
Patch (3.21 KB, patch)
2012-07-31 13:53 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-01 (310.40 KB, application/zip)
2012-07-31 14:28 PDT, WebKit Review Bot 		no flags
Details
Patch for landing (3.56 KB, patch)
2012-07-31 14:32 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-07-31 13:53:49 PDT
Created attachment 155627 [details] Patch
WebKit Review Bot
Comment 2 2012-07-31 14:28:31 PDT
Comment on attachment 155627 [details] Patch Attachment 155627 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13393784 New failing tests: css3/flexbox/floated-flexbox.html
WebKit Review Bot
Comment 3 2012-07-31 14:28:34 PDT
Created attachment 155635 [details] Archive of layout-test-results from gce-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Tony Chang
Comment 4 2012-07-31 14:32:38 PDT
Created attachment 155636 [details] Patch for landing
Tony Chang
Comment 5 2012-07-31 14:51:46 PDT
For completeness, I tried to see if we needed to update RenderBox::avoidsFloats to include new flexbox items, but I couldn't get that test to crash in either new or old flexbox. We probably fixed something else in old flexbox that causes the test to work.
WebKit Review Bot
Comment 6 2012-07-31 18:31:44 PDT
Comment on attachment 155636 [details] Patch for landing Clearing flags on attachment: 155636 Committed r124279: <http://trac.webkit.org/changeset/124279>
WebKit Review Bot
Comment 7 2012-07-31 18:31:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.