Bug 92866

Summary: MediaStream API: Add RTCPeerConnectionHandler infrastructure
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, gyuyoung.kim, jamesr, rakuco, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 92980    
Bug Blocks: 80589    
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from gce-cr-linux-01
none
Patch
abarth: review+
Patch for landing
none
Patch none

Tommy Widenflycht
Reported 2012-08-01 05:17:54 PDT
Introducing RTCPeerConnectionHandler & RTCPeerConnectionHandlerClient, together with the Chromium WebKit interface.
Attachments
Patch (30.08 KB, patch)
2012-08-01 05:32 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (30.06 KB, patch)
2012-08-01 05:39 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-01 (603.81 KB, application/zip)
2012-08-01 06:38 PDT, WebKit Review Bot 		no flags
Details
Patch (30.16 KB, patch)
2012-08-01 06:51 PDT, Tommy Widenflycht 		abarth: review+
DetailsFormatted DiffDiff
Patch for landing (30.06 KB, patch)
2012-08-02 01:57 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (29.92 KB, patch)
2012-08-02 06:42 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-08-01 05:32:12 PDT
Created attachment 155787 [details] Patch
WebKit Review Bot
Comment 2 2012-08-01 05:34:38 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Tommy Widenflycht
Comment 3 2012-08-01 05:39:47 PDT
Created attachment 155788 [details] Patch
Tommy Widenflycht
Comment 4 2012-08-01 05:42:03 PDT
The patch is on the large size but most of it is licences, and very little actual code.
WebKit Review Bot
Comment 5 2012-08-01 06:38:09 PDT
Comment on attachment 155788 [details] Patch Attachment 155788 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13403598 New failing tests: fast/mediastream/RTCPeerConnection.html
WebKit Review Bot
Comment 6 2012-08-01 06:38:15 PDT
Created attachment 155797 [details] Archive of layout-test-results from gce-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Tommy Widenflycht
Comment 7 2012-08-01 06:51:41 PDT
Created attachment 155800 [details] Patch
Adam Barth
Comment 8 2012-08-01 11:37:39 PDT
Comment on attachment 155800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155800&action=review > Source/Platform/chromium/public/Platform.h:414 > + // This is an highly experimental feature not yet in the WebRTC standard. I'd skip this comment. It's likely to get out of date quickly.
Tommy Widenflycht
Comment 9 2012-08-02 01:57:50 PDT
Created attachment 156008 [details] Patch for landing
Tommy Widenflycht
Comment 10 2012-08-02 03:11:12 PDT
Comment on attachment 155800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155800&action=review >> Source/Platform/chromium/public/Platform.h:414 >> + // This is an highly experimental feature not yet in the WebRTC standard. > > I'd skip this comment. It's likely to get out of date quickly. Removed.
WebKit Review Bot
Comment 11 2012-08-02 03:13:37 PDT
Comment on attachment 156008 [details] Patch for landing Rejecting attachment 156008 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13428121
WebKit Review Bot
Comment 12 2012-08-02 04:43:17 PDT
Comment on attachment 156008 [details] Patch for landing Clearing flags on attachment: 156008 Committed r124439: <http://trac.webkit.org/changeset/124439>
WebKit Review Bot
Comment 13 2012-08-02 04:43:24 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 14 2012-08-02 05:28:42 PDT
Re-opened since this is blocked by 92980
Tommy Widenflycht
Comment 15 2012-08-02 06:42:01 PDT
Created attachment 156069 [details] Patch
Tommy Widenflycht
Comment 16 2012-08-02 06:44:04 PDT
Previous patch broke chromium release Mac, due to an unused member variable. This time verified on a Mac.
WebKit Review Bot
Comment 17 2012-08-02 08:56:38 PDT
Comment on attachment 156069 [details] Patch Clearing flags on attachment: 156069 Committed r124460: <http://trac.webkit.org/changeset/124460>
WebKit Review Bot
Comment 18 2012-08-02 08:56:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.