Bug 94813

Summary: MediaStream API: Add readyState functionality to RTCPeerConnection
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: WebCore Misc.Assignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fishd, gustavo, jamesr, ojan, philn, tkent+wkapi, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 80589    
Attachments:
Description Flags
Patch
none
Patch none

Tommy Widenflycht
Reported 2012-08-23 07:33:41 PDT
This patch adds readyState functionality to RTCPeerConnection, together with related callbacks and methods.
Attachments
Patch (20.24 KB, patch)
2012-08-23 07:41 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (21.14 KB, patch)
2012-08-24 05:26 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2012-08-23 07:41:33 PDT
Created attachment 160160 [details] Patch
WebKit Review Bot
Comment 2 2012-08-23 07:44:12 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adam Barth
Comment 3 2012-08-23 10:23:06 PDT
Comment on attachment 160160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160160&action=review > Source/WebCore/platform/mediastream/RTCPeerConnectionHandlerClient.h:42 > + virtual void didChangeReadyState(uint32_t state) = 0; uint32_t -> ReadyState Perhaps we need to move the ReadyState enum to a more general location so we can reference it here?
Adam Barth
Comment 4 2012-08-23 10:23:35 PDT
Looks like you've got a compile error on GTK to work through as well.
Tommy Widenflycht
Comment 5 2012-08-24 05:26:49 PDT
Created attachment 160402 [details] Patch
Tommy Widenflycht
Comment 6 2012-08-24 05:27:23 PDT
Fixed. (In reply to comment #4) > Looks like you've got a compile error on GTK to work through as well.
Tommy Widenflycht
Comment 7 2012-08-24 05:28:16 PDT
Comment on attachment 160160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160160&action=review >> Source/WebCore/platform/mediastream/RTCPeerConnectionHandlerClient.h:42 >> + virtual void didChangeReadyState(uint32_t state) = 0; > > uint32_t -> ReadyState > > Perhaps we need to move the ReadyState enum to a more general location so we can reference it here? Fixed by moving the ReadyState definition to this class.
WebKit Review Bot
Comment 8 2012-08-24 08:09:57 PDT
Comment on attachment 160402 [details] Patch Clearing flags on attachment: 160402 Committed r126586: <http://trac.webkit.org/changeset/126586>
WebKit Review Bot
Comment 9 2012-08-24 08:10:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.